Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error during requestSignIn if contractId is invalid #195

Closed
kcole16 opened this issue Jan 22, 2020 · 2 comments · Fixed by #527
Closed

Return error during requestSignIn if contractId is invalid #195

kcole16 opened this issue Jan 22, 2020 · 2 comments · Fixed by #527
Assignees
@volovyks
Labels
bug Something isn't working P1 Very important

Comments

@kcole16
Copy link

kcole16 commented Jan 22, 2020

Similar to near/near-wallet#219.

Expected behavior
When entering an invalid (non-existent) contractId argument in nearlib.WalletAccount.requestSignIn, the developer should receive an error.
@janedegtiareva janedegtiareva added bug Something isn't working P1 Very important labels May 26, 2020
@behaviary
Copy link
Contributor

@kcole16 is this just in wallet? Is this solved? Not really sure how to fix this on near-api-js side right now.

@kcole16
Copy link
Author

kcole16 commented Jun 30, 2020

We've implemented a fix on the wallet side, but I do think we should generalize this somewhere, as this is really an error on the app developer's side and could occur with any wallet.

@volovyks volovyks assigned volovyks and unassigned chadoh Mar 11, 2021
@volovyks volovyks mentioned this issue Mar 11, 2021
Merged
@volovyks volovyks linked a pull request Mar 11, 2021 that will close this issue
requestSignIn throws error if contractId does not exist #527
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@volovyks volovyks

Labels
bug Something isn't working P1 Very important
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

requestSignIn throws error if contractId does not exist near/near-api-js
5 participants
@chadoh @janedegtiareva @volovyks @kcole16 @behaviary