Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limit faucet by IP #158

Open
2 tasks
kcole16 opened this issue Jun 2, 2020 · 2 comments
Open
2 tasks

Rate limit faucet by IP #158

kcole16 opened this issue Jun 2, 2020 · 2 comments

Comments

@kcole16
Copy link

kcole16 commented Jun 2, 2020

Overview

We're experiencing issues with users "mining" the faucet to accumulate large amounts of NEAR.

To prevent this, we should implement rate limiting by IP address.

Relevant route: https://github.com/near/near-contract-helper/blob/master/app.js#L83

Acceptance Criteria

  • A unique IP address is unable to receive more than 500 NEAR per hour (1 account)
  • Calls to /account return an error "Account limit reached. Try again in 60 minutes" if the IP is over the limit
@kcole16
Copy link
Author

kcole16 commented Jun 2, 2020

Closing for now, as we decided to adjust faucet amount instead

@vgrichina
Copy link
Contributor

@kcole16 I think we should re-open with lower priority. We still need to figure out long term solution.

Maybe for example we should always use POA setup as primary networks for development and have strict limits on testnet/betanet faucets, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants