Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TxFlow Missing Components #118

Closed
4 tasks
MaksymZavershynskyi opened this issue Nov 30, 2018 · 1 comment
Closed
4 tasks

TxFlow Missing Components #118

MaksymZavershynskyi opened this issue Nov 30, 2018 · 1 comment
Assignees
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.
Milestone

Comments

@MaksymZavershynskyi
Copy link
Contributor

MaksymZavershynskyi commented Nov 30, 2018

  • Currently TxFlow does not output consensus. They are partially computed inside TxFlow DAG but not exposed to the outside. We should compute them and stream them in the output stream of TxFlowTask.

  • MisbehaviorVerifier. TxFlow should should be able to report misbehavior as soon as it detects it, which can happen in the different parts of our infrastructure: in Message, DAG, TxFlowTask structs. For now MisbehaviorVerifier does not need to send it for slashing but can simply print it or write to a file for testing.

  • Replace hash with real crypto hash. We should be using crypto hash instead of the hashmap hash is some places.

  • Replace signature with real signature. TxFlow might need to link to the component that does the signing, since TxFlow should not have access to private keys.

@MaksymZavershynskyi MaksymZavershynskyi added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Nov 30, 2018
@MaksymZavershynskyi MaksymZavershynskyi added this to the MVB milestone Nov 30, 2018
@MaksymZavershynskyi MaksymZavershynskyi changed the title TxFlow Missing Components TxFlow DAG Missing Components Nov 30, 2018
@MaksymZavershynskyi MaksymZavershynskyi changed the title TxFlow DAG Missing Components TxFlow Missing Components Nov 30, 2018
@MaksymZavershynskyi
Copy link
Contributor Author

TxFlow is getting removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Development

No branches or pull requests

2 participants