Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement GC for remaining columns #2860

Closed
7 tasks done
Kouprin opened this issue Jun 17, 2020 · 1 comment · Fixed by #2891
Closed
7 tasks done

Implement GC for remaining columns #2860

Kouprin opened this issue Jun 17, 2020 · 1 comment · Fixed by #2891
Assignees
@Kouprin @ailisp
Labels
A-chain Area: Chain, client & related A-storage Area: storage and databases

Comments

@Kouprin
Copy link
Member

Kouprin commented Jun 17, 2020 •
edited

After #2802, it's possible to track easily columns that should be GCed or not.

There is a list of columns that should be GCed:

  • ColTransactionResult
  • ColOutcomesByBlockHash
  • ColStateDlInfos
  • ColBlockInfo
  • ColEpochInfo
  • ColLastBlockWithNewChunk
  • ColEpochStart

For all other columns there should be clear explanation why we don't GC them.
@Kouprin Kouprin self-assigned this Jun 17, 2020
@Kouprin Kouprin mentioned this issue Jun 17, 2020
Merged
@bowenwang1996 bowenwang1996 added A-chain Area: Chain, client & related A-storage Area: storage and databases labels Jun 22, 2020
@ailisp ailisp self-assigned this Jun 23, 2020
@Kouprin
Copy link
Member Author

Kouprin commented Jun 24, 2020 •
edited

I see no reason to clean ColLastBlockWithNewChunk however it's added.

This was referenced Jun 24, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kouprin Kouprin

@ailisp ailisp

Labels
A-chain Area: Chain, client & related A-storage Area: storage and databases
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(GC): GC remaining cols near/nearcore
3 participants
@Kouprin @ailisp @bowenwang1996