Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wasmtime usage #2895

Closed
MaksymZavershynskyi opened this issue Jun 24, 2020 · 0 comments
Closed

Fix Wasmtime usage #2895

MaksymZavershynskyi opened this issue Jun 24, 2020 · 0 comments
Assignees
Labels
A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) C-bug Category: This is a bug

Comments

@MaksymZavershynskyi
Copy link
Contributor

It seems like #2853 has changed between the final approval and the merge. We typically do not enforce undoing of the approvals when new commits are pushed after the approvals, because it makes our development cycles slower.

We need to return the following important code into near-vm-runner according to the discussion and the approvals:

Besides @SkidanovAlex has reported problems with compiling wasmtime on our CI, therefore the compilation flag should make wasmtime dependency optional and only included when the compilation flag is specified, see for the reference https://doc.rust-lang.org/cargo/reference/index.html

@MaksymZavershynskyi MaksymZavershynskyi added C-bug Category: This is a bug A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) labels Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

2 participants