Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable state sync for for the first epoch after sharding changes #4711

Closed
mzhangmzz opened this issue Aug 18, 2021 · 0 comments · Fixed by #5067
Closed

Disable state sync for for the first epoch after sharding changes #4711

mzhangmzz opened this issue Aug 18, 2021 · 0 comments · Fixed by #5067
Assignees
@mzhangmzz
Labels
A-chain Area: Chain, client & related T-core Team: issues relevant to the core team
Projects
Chain + Transaction Runtime Q3

Comments

@mzhangmzz
Copy link
Contributor

The current proposal of how to implement sharding upgrade is incompatible with how state sync is implemented. This is because state sync syncs to the state before the last block of the last epoch (say T-1). If number of shards changes between epoch T-1 and epoch T, this does not work.

The temporary solution for this is to disable state sync for the epoch when resharding happens.
@mzhangmzz mzhangmzz self-assigned this Aug 18, 2021
@mzhangmzz mzhangmzz added this to New Issues in Chain + Transaction Runtime Q3 via automation Aug 18, 2021
@mzhangmzz mzhangmzz mentioned this issue Aug 18, 2021
Merged
@bowenwang1996 bowenwang1996 added A-chain Area: Chain, client & related T-core Team: issues relevant to the core team labels Aug 19, 2021
@mzhangmzz mzhangmzz linked a pull request Nov 1, 2021 that will close this issue
make node panic if state sync to the first epoch after sharding upgrade #5067
Merged
Chain + Transaction Runtime Q3 automation moved this from New Issues to Done Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mzhangmzz mzhangmzz

Labels
A-chain Area: Chain, client & related T-core Team: issues relevant to the core team
Projects
Chain + Transaction Runtime Q3
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make node panic if state sync to the first epoch after sharding upgrade near/nearcore
2 participants
@bowenwang1996 @mzhangmzz