Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass tracked-shards to localnet in pytest correctly #8272

Closed
Longarithm opened this issue Dec 22, 2022 · 0 comments · Fixed by #8282
Closed

Pass tracked-shards to localnet in pytest correctly #8272

Longarithm opened this issue Dec 22, 2022 · 0 comments · Fixed by #8282
Assignees

Comments

@Longarithm
Copy link
Member

#8187 introduces tracked-shards for localnet and makes it "all" by default. However, pytest also uses localnet option, and in most of places it assumes that tracked-shards is "none". In some test, it even overrides tracked shards in client_config_changes.

It breaks at least one test (repro_2916.py) - we can't tell more because nayduck is broken. We need to find a way to pass this argument to pytest correctly. cc @wacban

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants