Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXPERIMENTAL_tx_status will give incomplete response after we release resharding #9545

Open
telezhnaya opened this issue Sep 20, 2023 · 0 comments

Comments

@telezhnaya
Copy link
Contributor

Underneath, it uses get_tx_status with fetch_receipt option.

We check if we are tracking current shard

// Check if we are tracking this shard.

If not, we add the request to the queue
if Self::need_request(tx_hash, &mut request_manager.tx_status_requests) {

Then, if the request is repeated, we should get it from the cache
{
let mut request_manager = self.request_manager.write().expect(POISONED_LOCK_ERR);
if let Some(res) = request_manager.tx_status_response.pop(&tx_hash) {
request_manager.tx_status_requests.pop(&tx_hash);
return Ok(Some(FinalExecutionOutcomeViewEnum::FinalExecutionOutcome(res)));
}
}

And we ignore fetch_receipt flag there.

It's not reproducible now because we haven't released resharding and we just don't use this logic. After introducing the release, we will not show requested receipts in the response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant