Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimate test coverage for our runtime code #9947

Closed
gmilescu opened this issue May 4, 2022 · 5 comments
Closed

Estimate test coverage for our runtime code #9947

gmilescu opened this issue May 4, 2022 · 5 comments
Labels
A-testing Area: Unit testing / integration testing GroomedA Node Node team P-medium Priority: medium T-node Team: issues relevant to the node experience team Task

Comments

@gmilescu
Copy link

gmilescu commented May 4, 2022

in #5054 and #5150 we noticed a couple of relatively easy to check corner cases which weren't caught by our test suite. Additionally, in #5121 (comment) I've noticed a branch (in a newley introduced code) which is not hit by our tests at all.

This brings up a question: how good is the coverage for our runtime logic? Given the above, I won't be surprised if we have some parts which are ignored by the tests completely.

I suggest running https://doc.rust-lang.org/nightly/unstable-book/compiler-flags/instrument-coverage.html once to get a rough understanding of how well do we fair.

Note: I emphatically do not suggest adding some coverage checks to CI, in my experience they are more about checkbox ticking than about actual improvements in quality.

[ND-80] created by None
@gmilescu
Copy link
Author

gmilescu commented May 4, 2022

bowenwang1996 commented:

Assigning it to @posvyatokum given that you are working on runtime related testing

by 557058:c020323a-70e4-4c07-9ccc-3ad89b1c02ec

@gmilescu
Copy link
Author

gmilescu commented May 4, 2022

stale[bot] commented:

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

by 557058:c020323a-70e4-4c07-9ccc-3ad89b1c02ec

1 similar comment
@gmilescu
Copy link
Author

gmilescu commented May 5, 2022

stale[bot] commented:

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

by 557058:c020323a-70e4-4c07-9ccc-3ad89b1c02ec

@gmilescu
Copy link
Author

matklad commented:

I believe we did this at some point. I remember seeing something like a `.zip` file with coverage report. We didn't act on that though.

by 557058:c020323a-70e4-4c07-9ccc-3ad89b1c02ec

@gmilescu gmilescu added the Node Node team label Oct 18, 2023
@gmilescu
Copy link
Author

Closing as duplicate of #5152.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing Area: Unit testing / integration testing GroomedA Node Node team P-medium Priority: medium T-node Team: issues relevant to the node experience team Task
Projects
None yet
Development

No branches or pull requests

1 participant