feat: add fast-forwarding #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miraclx
suggested changes
Feb 9, 2022
4 tasks
ChaoticTempest
force-pushed
the
feat/fast-forward
branch
from
7cccae3
to
25cd749
Compare
austinabell
approved these changes
Mar 25, 2022
workspaces/src/worker/impls.rs
Outdated
| @@ -77,6 +77,10 @@ where | |||
| ) -> ImportContractTransaction<'a, 'b> { | |||
| self.workspace.import_contract(id, worker) | |||
| } | |||
|
|
|||
| async fn fast_forward(&self, delta_height: u64) -> anyhow::Result<()> { | |||
There was a problem hiding this comment.
noting that adding this function to StatePatcher blurs that naming meaning. These things seem sandbox specific so not sure why the trait is needed yet
There was a problem hiding this comment.
hmm, yeah let's just get rid of the StatePatcher trait and expose Sandbox so people can just reference Worker<Sandbox> in their functions directly then. It's gonna be very sandbox specific behavior so might as well go that route
austinabell
reviewed
Mar 25, 2022
austinabell
approved these changes
Apr 4, 2022
There was a problem hiding this comment.
Didn't notice that you moved the logic similar to #102 for removing StatePatcher. I'd say pull this one in first and then I can resolve conflicts on mine
|
sounds good then |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
worker.fast_forward(x)specific API for simulating producingxnumber of blocks on the sandbox node. Also adds a simple example for fast forwarding and grabbing time specific data related to how many blocks have been produced before and after afast_forwardrequest.Mainly opening this one up for comments so we can review this one sooner than later, and will point to the specific nearcore version once near/nearcore#6211 merges