Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using semantic-release #48

Closed
bmullan91 opened this issue Feb 21, 2019 · 1 comment
Closed

Consider using semantic-release #48

bmullan91 opened this issue Feb 21, 2019 · 1 comment

Comments

@bmullan91
Copy link
Contributor

Notes

  • commits will need to follow a certain format fix, feat or BREAKING CHANGE
  • semantic-release figures out what the new version should be
  • generates release notes
  • generates git tag
  • publish the new release

see https://github.com/semantic-release/semantic-release for more info.

@jackdclark jackdclark added this to To do in GraphQL Hooks Feb 26, 2019
@jackdclark
Copy link
Member

jackdclark commented Mar 6, 2019

@bmullan91 I've been investigating this one this morning.

Lerna supports the conventional commit spec via config or a --conventional-commits flag. When run with this flag, lerna version will use the spec to determine the version bump and generate CHANGELOG.md files.

Lerna also has a --github-release flag - which, when used with --conventional-commits, will create an official GitHub release based on the changed packages.

As we already follow a squash based workflow on this project when merging PRs, it wouldn't be much overhead to enforce us as maintainers to use conventional commits when merging PRs & we'll then get all of the above. It also means we wouldn't have to force contributors to follow the spec when raising PRs, which could be off-putting if they have to follow too much process. (See Do all my contributors need to use the conventional commit specification?)

Thoughts @bmullan91 @Joezo?

@jackdclark jackdclark mentioned this issue Mar 6, 2019
3 tasks
GraphQL Hooks automation moved this from To do to Done Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
GraphQL Hooks
  
Done
Development

No branches or pull requests

2 participants