This repository has been archived by the owner on Jun 20, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17
Document if page
is 0 or 1 indexed.
#9
Comments
@AndreasMadsen It was a typo on API spec. API use 1 by default. I should have treated zeros as "not-provided", which means defaulting to 1. Fixed now. |
@ShogunPanda So it is 0 indexed? It is still not documented. |
It's 1 indexed, as all REST APIs. That's why is not explicitly documented. I just added the explicit documentation. |
@ShogunPanda Great. So why is the minimum value 0 in a9eaae5? |
Well, I just wanted to provide a fallback in case users don't read the docs :) |
@ShogunPanda It is up to you. But that sounds like a really bad idea because it teaches the wrong API. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The error message for
page = 0
is also not great.PS: page is 1 indexed.
The text was updated successfully, but these errors were encountered: