Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node & Staking and visual changes #149

Merged
merged 6 commits into from Nov 7, 2019
Merged

Node & Staking and visual changes #149

merged 6 commits into from Nov 7, 2019

Conversation

@marcinbodnar
Copy link
Collaborator

marcinbodnar commented Sep 24, 2019

No description provided.

@marcinbodnar marcinbodnar requested a review from vgrichina Sep 24, 2019
@render

This comment has been minimized.

Copy link

render bot commented Sep 24, 2019

@render

This comment has been minimized.

Copy link

render bot commented Sep 24, 2019

@kcole16

This comment has been minimized.

Copy link
Contributor

kcole16 commented Sep 24, 2019

Couple of comments:

  • On /staking, placeholder text should be “example: 15” and
  • “0% of Total” is shown in attoNear, should be in Near (divide by 10^18)

Screenshot

@marcinbodnar

This comment has been minimized.

Copy link
Collaborator Author

marcinbodnar commented Sep 24, 2019

@kcole16 placeholder fixed, when it comes to “0% of Total” it is related to issue #138, so I will fix it when Balance component will work fine.

@icerove

This comment has been minimized.

Copy link
Member

icerove commented Sep 25, 2019

when you really enter 0.0001 amount, the token will change the image to n/1000, which is a millitoken for near token, and if this is confused, just cancel that token image and use near token only

@marcinbodnar marcinbodnar force-pushed the node-staking branch from 8d04ac2 to 12d59a1 Oct 29, 2019
@render

This comment has been minimized.

Copy link

render bot commented Oct 29, 2019

A deploy for your Render PR Server at https://near-wallet-staging-pr-149.onrender.com just failed.

View details on your dashboard at https://dashboard.render.com/web/srv-bm5264918mo9itgidjg0.

@render

This comment has been minimized.

Copy link

render bot commented Oct 29, 2019

A deploy for your Render PR Server at https://near-wallet-pr-149.onrender.com just failed.

View details on your dashboard at https://dashboard.render.com/web/srv-bm5264918mo9itgidjbg.

@vgrichina vgrichina merged commit e86d906 into master Nov 7, 2019
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.