Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement API for signing individual transaction #240

Merged
merged 17 commits into from Dec 11, 2019
Merged

Implement API for signing individual transaction #240

merged 17 commits into from Dec 11, 2019

Conversation

vgrichina
Copy link
Contributor

No description provided.

@render
Copy link

render bot commented Nov 19, 2019

Your Render PR Server URL is https://near-wallet-pr-240.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-bna5p2nd1hnngg7s5o50.

@render
Copy link

render bot commented Nov 19, 2019

Your Render PR Server URL is https://near-wallet-staging-pr-240.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-bna5p2vd1hnngg7s5ob0.

@render
Copy link

render bot commented Nov 19, 2019

Your Render PR Server at https://near-wallet-pr-240.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bna5p2nd1hnngg7s5o50.

@render
Copy link

render bot commented Nov 19, 2019

Your Render PR Server at https://near-wallet-staging-pr-240.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bna5p2vd1hnngg7s5ob0.

@render
Copy link

render bot commented Nov 19, 2019

Your Render PR Server at https://near-wallet-pr-240.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bna5p2nd1hnngg7s5o50.

@render
Copy link

render bot commented Nov 19, 2019

Your Render PR Server at https://near-wallet-staging-pr-240.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bna5p2vd1hnngg7s5ob0.

@render
Copy link

render bot commented Dec 5, 2019

Your Render PR Server at https://near-wallet-pr-240.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bna5p2nd1hnngg7s5o50.

@render
Copy link

render bot commented Dec 5, 2019

Your Render PR Server at https://near-wallet-staging-pr-240.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bna5p2vd1hnngg7s5ob0.

@render
Copy link

render bot commented Dec 5, 2019

Your Render PR Server at https://near-wallet-staging-pr-240.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bna5p2vd1hnngg7s5ob0.

@render
Copy link

render bot commented Dec 5, 2019

Your Render PR Server at https://near-wallet-pr-240.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bna5p2nd1hnngg7s5o50.

1 similar comment
@render
Copy link

render bot commented Dec 5, 2019

Your Render PR Server at https://near-wallet-pr-240.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bna5p2nd1hnngg7s5o50.

@render
Copy link

render bot commented Dec 5, 2019

Your Render PR Server at https://near-wallet-staging-pr-240.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bna5p2vd1hnngg7s5ob0.

1 similar comment
@render
Copy link

render bot commented Dec 7, 2019

Your Render PR Server at https://near-wallet-staging-pr-240.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bna5p2vd1hnngg7s5ob0.

@render
Copy link

render bot commented Dec 7, 2019

Your Render PR Server at https://near-wallet-pr-240.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bna5p2nd1hnngg7s5o50.

@render
Copy link

render bot commented Dec 7, 2019

Your Render PR Server at https://near-wallet-staging-pr-240.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bna5p2vd1hnngg7s5ob0.

@render
Copy link

render bot commented Dec 7, 2019

Your Render PR Server at https://near-wallet-pr-240.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bna5p2nd1hnngg7s5o50.

@render
Copy link

render bot commented Dec 7, 2019

Your Render PR Server at https://near-wallet-staging-pr-240.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bna5p2vd1hnngg7s5ob0.

@render
Copy link

render bot commented Dec 7, 2019

Your Render PR Server at https://near-wallet-pr-240.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bna5p2nd1hnngg7s5o50.

@render
Copy link

render bot commented Dec 7, 2019

Your Render PR Server at https://near-wallet-pr-240.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bna5p2nd1hnngg7s5o50.

@render
Copy link

render bot commented Dec 7, 2019

Your Render PR Server at https://near-wallet-staging-pr-240.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bna5p2vd1hnngg7s5ob0.

@vgrichina vgrichina marked this pull request as ready for review December 7, 2019 08:38
@vgrichina
Copy link
Contributor Author

@kcole16 not really done yet, but I plan to merge to avoid diverging from master too much (existing apps won't call /sign route for now)

@kcole16
Copy link
Contributor

kcole16 commented Dec 9, 2019

@vgrichina Makes sense. What should I review in this PR for now?

@vgrichina
Copy link
Contributor Author

@vgrichina Makes sense. What should I review in this PR for now?

that's more like just FYI at this point

something to pay attention to though is that I had to hide some stuff we had in design, e.g. contract name in multiple places. It didn't match the model of multiple transactions (to different contracts) per single flow.

@vgrichina
Make transaction signing API work (doesn't submit yet)
b8eae29
@vgrichina
Fix misnaming of SignTransferDetails as SignTransferReady
8e7b976
@vgrichina
Move transaction parsing into Redux
2a46846
@vgrichina
Make transactions fees / sensitive actions calculation more readable
fcf23e9
@vgrichina
Fix to show contract ID properly in details
4460f83
@vgrichina
Make it clear that app title is fake
e0a2dec
@vgrichina
Fix More information button for when there is 0 sensitive actions
b8d90e7
@vgrichina
Display total amount of transfers from transaction
600c9c3
@vgrichina
Don’t underline <Balance>
cc762be
@vgrichina
Hide fake data on happy flow for sign transaction
2b5d7da
@vgrichina
Prototype signing and sending transactions
d44a4a8
@vgrichina
Reformat all Sign components to 4 spaces
631d9aa
@vgrichina
Hide dummy contract name on transfer cancelled screen
c60c145
@vgrichina
Lint fixes
569fe9b
@vgrichina
Display app title based on Referrer
b78e453
@vgrichina
Added comment about referrer not being set
6b22d17
@vgrichina vgrichina merged commit c9b0204 into master Dec 11, 2019
@render
Copy link

render bot commented Dec 11, 2019

Your Render PR Server at https://near-wallet-pr-240.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bna5p2nd1hnngg7s5o50.

@vgrichina vgrichina mentioned this pull request Dec 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcole16 kcole16 kcole16 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vgrichina @kcole16