Allow genesis tool to specify shards to track #1726
Conversation
Codecov Report
@@ Coverage Diff @@
## staging #1726 +/- ##
===========================================
- Coverage 80.75% 80.61% -0.14%
===========================================
Files 132 132
Lines 25421 25352 -69
===========================================
- Hits 20528 20437 -91
- Misses 4893 4915 +22
Continue to review full report at Codecov.
|
| .get_matches(); | ||
|
|
||
| let home_dir = matches.value_of("home").map(|dir| Path::new(dir)).unwrap(); | ||
| let chain_id = matches.value_of("chain-id").expect("Chain id is requried"); | ||
| csv_to_json_configs::csv_to_json_configs(home_dir, chain_id.to_string()); | ||
| let tracked_shards: HashSet<ShardId> = match matches.value_of("tracked-shards") { |
There was a problem hiding this comment.
How is this arg used? The usage of this command line tool is to allow a group of participants who share the same csv file to create the same genesis config. Are they all going to track the same set of shards? Will this set of shards include all shards existing, if not who is going to track the remaining shards?
There was a problem hiding this comment.
Please add explanation to the arg's description.
There was a problem hiding this comment.
Tracked shards are independent of genesis. They are specified by the node if the node wants to always track some shards. I'll add an explanation.
There was a problem hiding this comment.
Could you also answer:
Are they all going to track the same set of shards? Will this set of shards include all shards existing, if not who is going to track the remaining shards?
There was a problem hiding this comment.
And add this explanation to the arg description.
There was a problem hiding this comment.
No. As I said tracked-shards is specified by the node. If a node wants to track some shards, it is their decision. It is not related in any way to how any other nodes make this decision.
There was a problem hiding this comment.
How do people decide what shards to track? Let's say we have stake wars participants, how does participant Alice decide that she wants to track some set of shards, e.g. "1,5,6"? How do they know what is the total number of shards?
| .get_matches(); | ||
|
|
||
| let home_dir = matches.value_of("home").map(|dir| Path::new(dir)).unwrap(); | ||
| let chain_id = matches.value_of("chain-id").expect("Chain id is requried"); | ||
| csv_to_json_configs::csv_to_json_configs(home_dir, chain_id.to_string()); | ||
| let tracked_shards: HashSet<ShardId> = match matches.value_of("tracked-shards") { |
There was a problem hiding this comment.
Could you also answer:
Are they all going to track the same set of shards? Will this set of shards include all shards existing, if not who is going to track the remaining shards?
| .get_matches(); | ||
|
|
||
| let home_dir = matches.value_of("home").map(|dir| Path::new(dir)).unwrap(); | ||
| let chain_id = matches.value_of("chain-id").expect("Chain id is requried"); | ||
| csv_to_json_configs::csv_to_json_configs(home_dir, chain_id.to_string()); | ||
| let tracked_shards: HashSet<ShardId> = match matches.value_of("tracked-shards") { |
There was a problem hiding this comment.
How do people decide what shards to track? Let's say we have stake wars participants, how does participant Alice decide that she wants to track some set of shards, e.g. "1,5,6"? How do they know what is the total number of shards?
|
It is completely up to the discretion of the person running the node to track shards. If they want to track any shard for whatever reason, they can. I am just providing a convenient way for people to do it so that they don't have to modify config file after it is generated. Until we have dynamic resharding, the number of shards is fixed (set in genesis). |
Also fix the minor issue that genesis tool requires validator_key.json to exist.