[bug] 08 stage being rendered/deployed when it shouldn't be

[iameskild]

@viniciusdc and I have both run into the following error during our recent deployment testing:

INFO:qhub.provider.terraform:terraform apply directory=stages/08-enterprise-qhub targets=[]
INFO:qhub.provider.terraform: terraform at /var/folders/ny/_kl83bcn59q8dngjrh_4qhjr0000gn/T/terraform/1.0.5/terraform
[terraform]: ╷
[terraform]: │ Error: Reference to undeclared input variable
[terraform]: │ 
[terraform]: │   on external-container-registry.tf line 2, in module "external-container-reg":
[terraform]: │    2:   count = var.external_container_reg.enabled ? 1 : 0
[terraform]: │ 
[terraform]: │ An input variable with the name "external_container_reg" has not been
[terraform]: │ declared. This variable can be declared with a variable
[terraform]: │ "external_container_reg" {} block.
[terraform]: ╵

Problem encountered: Terraform error

[viniciusdc]

Thanks, @iameskild for opening this issue, I just encountered this issue today when I deployed from a branch based on main (recently created). Originally I thought it was related to #1053, based on the error message and the stages files -- the external-container-registry.tf was rendered in the wrong destination.

The current behavior of render is to copy the files located in the source directory, e.g the templates folder located in the package installation dir (if a local install is made, it should reflect the same structure as your working branch).

So, by inspecting my local files, I noticed that the external-container-registry.tfmentioned above, was moved correctly to the 03-Kubernetes-initialize stage. But when inspecting the site-packages/qhub folder, it was not reflecting the actual structure of the repo (e.g the file was in the wrong place)

I've attempted to create a fresh new env and install qhub again from the local repo (pip install . in sync with main), but the same issue showed up. I was able to fix it, by installing from the repo URL

[danlester]

I have added #1049 to the 0.4 milestone since it should solve issues like this.

[costrouc]

Going to close this since it is only an issue for developers that have deployed within a two week period of this issue. Between #1003 and #1069. The fix if you have deployed within this window just delete your stages directory manually.