Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Dask environment not working due to recent package release #1212

Closed
viniciusdc opened this issue Mar 30, 2022 · 3 comments · Fixed by #1224
Closed

[BUG] - Dask environment not working due to recent package release #1212

viniciusdc opened this issue Mar 30, 2022 · 3 comments · Fixed by #1224
Assignees
Labels
area: integration/Dask Issues related to Dask on QHub area: user experience 👩🏻‍💻 type: bug 🐛 Something isn't working

Comments

@viniciusdc
Copy link
Contributor

OS system and architecture in which you are running QHub

Linux

Expected behavior

When executing the simple dask-gateway pipeline we should be able to susceffuly launch a dask scheduler pod and a cluster instance.Succesful

Actual behavior

Executing the cluster = gateway.new_cluster() block from the above docs, leads to an unexpected error during spawning of the Dask scheduler. Upon further inspection of the scheduler logs, we can see the same error message as shown in this issue.

Even though we currently pin the necessary version so dask within qhub-dask meta-package, we still need to add a new exception to avoid the new version of click which was the root cause of the problem.

image

Possible Solution

Add the following to the dask environment upon initialization

 - click ~= 8.1.0 # Or downgrade and pin to 8.0.2

How to Reproduce the problem?

In the description

Command output

No response

Versions and dependencies used.

Latest qhub on main, but the environment build is independent of cli version

Compute environment

No response

Integrations

No response

Anything else?

No response

@viniciusdc viniciusdc added type: bug 🐛 Something isn't working area: user experience 👩🏻‍💻 area: integration/Dask Issues related to Dask on QHub labels Mar 30, 2022
@iameskild iameskild self-assigned this Mar 31, 2022
@magsol magsol added this to the Release v0.4.1 milestone Mar 31, 2022
@iameskild
Copy link
Member

Until the issue is resolved upstream, we can pin click in our qhub-dask meta package.
conda-forge/qhub-dask-feedstock#11

@viniciusdc
Copy link
Contributor Author

viniciusdc commented Mar 31, 2022

Until the issue is resolved upstream, we can pin click in our qhub-dask meta package. conda-forge/qhub-dask-feedstock#11

Just I quick commented that I only spotted now, we didn't update qhub-dask in the dask-env config to 0.4.0 when we released: https://github.com/Quansight/qhub/blob/56ffa7b8607acd8172b9fb1025bbfeedb80ec6c4/qhub/initialize.py#L214, should this go to post?

@iameskild
Copy link
Member

That's a good catch! I would say say yes since it's a minor change that should've been caught earlier and will ensure that click related issue is actually addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: integration/Dask Issues related to Dask on QHub area: user experience 👩🏻‍💻 type: bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants