Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Optionally add RBAC permissions for AWS EKS cluster #648

Closed
brl0 opened this issue Jun 11, 2021 · 5 comments
Closed

[enhancement] Optionally add RBAC permissions for AWS EKS cluster #648

brl0 opened this issue Jun 11, 2021 · 5 comments
Labels
needs: discussion 💬 Needs discussion with the rest of the team status: stale 🥖 Not up to date with the default branch - needs update type: enhancement 💅🏼 New feature or request

Comments

@brl0
Copy link
Contributor

brl0 commented Jun 11, 2021

Description

After deploying qhub, additional steps are necessary to grant RBAC permissions to other AWS administrators.

Suggestion

It would be convenient to have an option to grant permissions to other users.
Another, possibly better approach, would be to take a list of users in the config file and create an IAM group and then grant permissions to that group.
This approach seems likely to be potentially adaptable to providers other than AWS.

Context

This would help simplify the management of the cluster by ensuring designated IAM users have appropriate access to the cluster.

@iameskild, @tylerpotts, can you provide additional details about how permissions need to be added currently?

@brl0
Copy link
Contributor Author

brl0 commented Jun 11, 2021

Possibly related to #12.

@costrouc costrouc added the type: enhancement 💅🏼 New feature or request label Jun 11, 2021
@costrouc
Copy link
Member

After deploying qhub, additional steps are necessary to grant RBAC permissions to other AWS administrators.

@brl0 do you have any ideas how we could automate this in terraform? From what I remember you have to add/modify a resource in kubernetes.

@costrouc costrouc added needs: discussion 💬 Needs discussion with the rest of the team client-funded labels Jun 11, 2021
@brl0
Copy link
Contributor Author

brl0 commented Jun 11, 2021

Good question, off the top of my head, I would think we might be able to create the appropriate roles or role bindings needed with the standard kubernetes provider, and if not, perhaps using a kubernetes_manifest from the kubernetes-alpha provider, at least as a fall back approach.

I think provisioning a group directly in the cloud provider's IAM and then granting permission to that group would be more maintainable, if that is possible.

@github-actions
Copy link

This issue has been automatically marked as stale because there was no recent activity in 60 days. Remove the stale label or add a comment, otherwise, this issue will automatically be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the status: stale 🥖 Not up to date with the default branch - needs update label Aug 11, 2021
@github-actions
Copy link

This issue was closed because it has been stalled for 7 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: discussion 💬 Needs discussion with the rest of the team status: stale 🥖 Not up to date with the default branch - needs update type: enhancement 💅🏼 New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants