Honor authorization on default actions #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. I pulled that into my fork here. |
|
hi @zorab47, finally my company decided to not work anymore on this project, are you still interested in maintaining this gem? If so I'll transfer the repo ownership, let me know! |
|
@nebirhos, yeah I'm happy to continue maintaining the gem. Transfering ownership doesn't break exisintg references to your repo mentioned in Gemfiles via URL does it? |
|
@zorab47 🙇 ! No it doesn't break anything, as you can see this repo is already under unmantained-activeadmin-plugins. GitHub magic I sent you an email, thanks again! |
|
@chaupt, already merged it in a different branch. Thanks for the PR!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ensures that the default actions use the configured authorization adapter in a manner identical to activeadmin's approach (as of this PR).