Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explanation for Render() #61

Closed
2 of 6 tasks
first-timers bot opened this issue Oct 4, 2018 · 2 comments
Closed
2 of 6 tasks

Explanation for Render() #61

first-timers bot opened this issue Oct 4, 2018 · 2 comments

Comments

@first-timers
Copy link

first-timers bot commented Oct 4, 2018

πŸ†•πŸ₯☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you πŸ’

About First Timers Only.

πŸ€” What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

πŸ“‹ Step by Step

  • πŸ™‹ Claim this issue: Comment below.

    Once claimed we add you as contributor to this repository.

  • πŸ‘Œ Accept our invitation to this repository. Once accepted, assign yourself to this issue

  • πŸ“ Update the file src/utils.js in the squirrelly repository (press the little pen Icon) and edit the line as shown below.

@@ -18,6 +18,8 @@ export function defineNativeHelper (name, obj) {
 }
 
 export function Render (template, options) {
+  // If the template parameter is a function, call that function with (options, Sqrl)
+  // If it's a string, first compile the string and then call the function
   if (typeof template === 'function') {
     return template(options, Sqrl)
   } else if (typeof template === 'string') {
  • πŸ’Ύ Commit your changes

  • πŸ”€ Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can edit files directly in your browser

  • 🏁 Done Ask in comments for a review :)

πŸ€”β“ Questions

Leave a comment below!

This issue was created by First-Timers-Bot.

@vincentle
Copy link

First time issue claim

@nebrelbug
Copy link
Collaborator

@vincentle awesome! Reserved.

@vincentle vincentle mentioned this issue Oct 4, 2018
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants