Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event subscribers loading Issue (3757) #50

Closed
spaghetticode opened this issue Sep 11, 2020 · 1 comment
Closed

Event subscribers loading Issue (3757) #50

spaghetticode opened this issue Sep 11, 2020 · 1 comment
Assignees
@spaghetticode
Projects
Solidus Squad Core

Comments

@spaghetticode
Copy link
Member

See solidusio#3757

Event subscribers may end up being subscribed multiple times. This happens with rails 6.x applications only. There are some quick & dirty fixes for this, but switching to a more robust way of managing subscribers will help in avoiding such issues.
@spaghetticode spaghetticode created this issue from a note in Solidus Squad Core (In Progress) Sep 11, 2020
@spaghetticode spaghetticode self-assigned this Sep 11, 2020
@spaghetticode
Copy link
Member Author

spaghetticode commented Sep 11, 2020 •
edited

PR solidusio#3758 should fix the issue. ATM it's still WIP, CI is failing sometimes probably due to the order execution of some events related specs.

@spaghetticode spaghetticode moved this from In Progress to Review in Solidus Squad Core Oct 30, 2020
@spaghetticode spaghetticode moved this from Review to Done in Solidus Squad Core Oct 30, 2020
@elia elia closed this as completed Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spaghetticode spaghetticode

Labels
None yet
Projects
No open projects
Solidus Squad Core
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elia @spaghetticode