Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"claim tokens" in example.html 404 #58

Closed
1c7 opened this issue Aug 20, 2018 · 8 comments
Closed

"claim tokens" in example.html 404 #58

1c7 opened this issue Aug 20, 2018 · 8 comments

Comments

@1c7
Copy link
Contributor

1c7 commented Aug 20, 2018

2018-August-20

1. Expect

claim Testnet token successfully when click "claim token"
image

Note: I did some change to source code, so in above screenshot, part of text is in Chinese. the original example.html is all English

2. What actually happen

I get 404 error

image
image

Please fix it

image

@1c7
Copy link
Contributor Author

1c7 commented Aug 20, 2018

Chrome developer tool, network tab

image

@1c7
Copy link
Contributor Author

1c7 commented Aug 20, 2018

Question

I know developer can claim token here:
https://testnet.nebulas.io/claim/
image

so are you guys gonna fix this claim token API in example.html, or just replace this Step 2
with this address: https://testnet.nebulas.io/claim/ ?

@yupnano
Copy link
Contributor

yupnano commented Aug 20, 2018

The claim token API in example.html is no longer supported. You should claim token manually here.

This is because there is always someone trying to claim testnet tokens with scripts.

@1c7
Copy link
Contributor Author

1c7 commented Aug 20, 2018

@yupnano
Understood.

So example.html Step 2 should display this link: https://testnet.nebulas.io/claim/
not a button anymore.

Should I send a PR? or you change it? it just couple line of code

@1c7 1c7 closed this as completed Aug 20, 2018
@yupnano
Copy link
Contributor

yupnano commented Aug 20, 2018

please send a PR, 👍

@1c7
Copy link
Contributor Author

1c7 commented Aug 20, 2018

@yupnano no problem :)
I would send PR in about 5 minute

@1c7
Copy link
Contributor Author

1c7 commented Aug 20, 2018

@yupnano done.
#60

@yupnano
Copy link
Contributor

yupnano commented Aug 20, 2018

Many thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants