Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom amount is not enough when using with large durations #2

Open
nipunasudha opened this issue May 28, 2020 · 4 comments
Open

Zoom amount is not enough when using with large durations #2

nipunasudha opened this issue May 28, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request In progress
Milestone

Comments

@nipunasudha
Copy link

nipunasudha commented May 28, 2020

When the total duration of the timeline is about 200 days, this is the maximum zoom possible.

Screenshot_20200528-144638_Project_Manager_Dev

Is there any way I can provide max & min zoom levels?

Note:
I noticed a pixelPerSeconds measure throughout the plugin source. Would that be an appropriate measure for larger durations? Could it introduce problems due to double accuracy?

Edit:
Oh wait, there is no zoom limit. I can zoom more and more, but each time I zoom, it zooms less and less. At the end it gets really laggy and I have to do the zoom gesture multiple times to zoom even a little bit. And the app freezes after that.

I don't know the reason for this, but if the reason is Flutter being overwhelmed by the length of the TimelineEditorBox, you may have to render only the part of the TimelineEditorBox that is visible by dynamically resizing the Box just enough to cover the visible width. When the user scrolls, the box size & position should readjust.

A double variable reaching 0 or Inf could also be the reason for this behavior.

@neckaros
Copy link
Owner

Thanks for the report. I don’t deal with big timeline so I didn’t saw this issue. I will look into it

@neckaros neckaros self-assigned this May 31, 2020
@neckaros neckaros added the enhancement New feature or request label May 31, 2020
@neckaros neckaros added this to the 4.0 milestone May 31, 2020
@neckaros
Copy link
Owner

Sorry I have a lot of work so I could not spend much time on this.

I have a version in development that use a list builder for better performance. I just need to fix a scroll offset mismatch between time indicator and elements when zooming

@nipunasudha
Copy link
Author

Sorry I have a lot of work so I could not spend much time on this.

I have a version in development that use a list builder for better performance. I just need to fix a scroll offset mismatch between time indicator and elements when zooming

Thank you for the update. Is it on master? I can fork and try to fix it.

@neckaros
Copy link
Owner

i uploaded it to master. I will try to spend time on it next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request In progress
Projects
None yet
Development

No branches or pull requests

2 participants