Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

different erfcx approximation error on pytorch #2

Closed
gaosh opened this issue Jun 16, 2018 · 2 comments
Closed

different erfcx approximation error on pytorch #2

gaosh opened this issue Jun 16, 2018 · 2 comments

Comments

@gaosh
Copy link

gaosh commented Jun 16, 2018

Hi, I try to re-implement your paper on pytorch. I changed your erfcx function to adapt pytorch tensor. After compared to the values of special.erfcx(x), the average absolute error is approximate 2.11-08, and average relative error is approximate 3.91e-08, both are much larger than your erfcx approximation. Could this be a problem?

Thanks ,
Shangqian

@da-molchanov
Copy link
Collaborator

Dear Shangqian,
3.91e-0.8 relative error in erfcx seems as a tight enough approximation. I don't think it would cause any problems. We only use erfcx to calculate the mean and the snr of the variational distribution and only use it during pruning and inference. It would not affect training at all.

Best regards,
Dmitry

@gaosh
Copy link
Author

gaosh commented Jun 17, 2018

Thanks for your reply.

@gaosh gaosh closed this as completed Jun 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants