Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed unnecessary margins on nested lists #57

Closed
wants to merge 1 commit into from
Closed

Fixed unnecessary margins on nested lists #57

wants to merge 1 commit into from

Conversation

zzzzBov
Copy link

@zzzzBov zzzzBov commented Nov 4, 2011

Some browsers remove top and bottom margins by default which enhances readability of nested lists.

@necolas necolas closed this in 3404fcb Nov 4, 2011
@necolas
Copy link
Owner

necolas commented Nov 4, 2011

I would expect

ul {
    margin: 1em 0;
}

to include margins on nested lists. Your code would have interfered with this author expectation if they tried to customise margins later in the stylesheet. So I've just normalized the left margin and left the vertical margins alone altogether. Thanks

@zzzzBov
Copy link
Author

zzzzBov commented Nov 4, 2011

Good choice. I was a little concerned about the specificity of li ul, li ol getting in the way.

@zzzzBov
Copy link
Author

zzzzBov commented Nov 4, 2011

I did some browser testing, and unfortunately IE statically defines margins on ul and ol, which means that a larger font-size will create differing margins in different browsers. I'd recommend just reverting back to margin: 1em 0; Devs can always add the sub-list fix manually afterwards.

@necolas
Copy link
Owner

necolas commented Feb 24, 2012

@zzzzBov This should be fixed in the latest version of the file. Thanks for bringing up these issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants