Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider: implementation #1022

Closed
necolas opened this issue Jul 7, 2018 · 7 comments
Closed

Slider: implementation #1022

necolas opened this issue Jul 7, 2018 · 7 comments

Comments

@necolas
Copy link
Owner

necolas commented Jul 7, 2018

https://facebook.github.io/react-native/docs/slider

@necolas necolas mentioned this issue Jul 7, 2018
19 tasks
@piranna
Copy link

piranna commented Jul 7, 2018

@necolas
Copy link
Owner Author

necolas commented Jul 7, 2018

That implementation isn't accessible, RTL-compatible, or performant

@tafelito
Copy link

tafelito commented Jul 23, 2018

what about https://github.com/ismnoiet/react-native-range-slider or https://github.com/ptomasroos/react-native-multi-slider?

Actually the first one is ios only, so it won't work

@necolas
Copy link
Owner Author

necolas commented Mar 6, 2019

Slider has moved out of RN core to https://github.com/react-native-community/react-native-slider

@mikeaustin
Copy link

https://github.com/react-native-community/react-native-slider doesn't work with create-react-app since main points to src/index.js. react-native projects compile node_modules, while create-react-app doesn't. I always feel CRA is too restrictive-it would be nice to allow some form of configuration. There's react-app-rewired, but I'd like something more stable.

@necolas
Copy link
Owner Author

necolas commented Jul 16, 2019

Open an issue against that repo

@mikeaustin
Copy link

@necolas I was just adding context to this ticket. But yes, nothing to do here. I was just disappointed that react-native split out their slider from the main branch, and that it doesn't work with CRA/RNW out of the box. I'm using the non-accessible, non-RTL-compatible, non-performant component for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants