Exceptions aren't caught during check!

[vemv]

Bug report

Brief

Exceptions aren't caught when check! invokes the passed predicates.

Expected behavior

(check! pos? nil) is handled gracefully

Actual behavior

An error is thrown opaquely. Particularly, this makes speced/defn less useful

Reproduction steps

(check! pos? nil)

Screenshot, stacktrace, etc

unit.nedap.utils.speced.defn.destructuring> (check! pos? nil)
Execution error (NullPointerException) at unit.nedap.utils.speced.defn.destructuring/eval190893 (form-init2166769074214536620.clj:1).
null
#error {
 :cause nil
 :via
 [{:type java.lang.NullPointerException
   :message nil
   :at [clojure.lang.Numbers ops "Numbers.java" 1068]}]
 :trace
 [[clojure.lang.Numbers ops "Numbers.java" 1068]
  [clojure.lang.Numbers isPos "Numbers.java" 121]
  [clojure.core$pos_QMARK_ invokeStatic "core.clj" 1252]
  [clojure.core$pos_QMARK_ invoke "core.clj" 1247]
  [clojure.spec.alpha$spec_impl$reify__1987 conform_STAR_ "alpha.clj" 875]
  [clojure.spec.alpha$valid_QMARK_ invokeStatic "alpha.clj" 755]
  [clojure.spec.alpha$valid_QMARK_ invoke "alpha.clj" 751]

Environment info

Happens on any util.spec version

---

Tech improvement

Proposal

• Catch the exception
• Make Expound print something pretty
  • See nedap.utils.spec.impl.check

Alternatives and comparison

• Let it fail opaquely
  • I don't see an advantage, other than maintaining less code