Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output_file setting should be changelog instead #77

Open
nedbat opened this issue Jan 14, 2023 · 1 comment
Open

output_file setting should be changelog instead #77

nedbat opened this issue Jan 14, 2023 · 1 comment

Comments

@nedbat
Copy link
Owner

nedbat commented Jan 14, 2023

Originally, scriv only wrote to changelog files, so output_file seemed right. But the github-release command reads from the file. A better name would be changelog (or changelog_file) for the setting. Of course, the old setting would still be recognized so people wouldn't be broken.

@nedbat
Copy link
Owner Author

nedbat commented Jan 15, 2023

Also, insert_marker should be start_marker, especially since the corresponding setting for the end is already called end_marker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant