Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple CC / BCC, Kotlin refactor #47

Merged
merged 4 commits into from Dec 22, 2022
Merged

Conversation

NarvalNudiste
Copy link
Contributor

Hey,

We started to use maildroid for the mailing part of our company app and I needed to make some changes.
This should not break anything when migrating from previous versions.

  • Merged the recipient and recipients var into one single list, to be able to add one or more recipients with the same method call
  • Did the same for cc, bcc fields
  • Reworked the attachment system to allow renaming (filename is optional)
  • Unified the log tag (you can of course ignore this if you needed specific tags)
  • Simplified some parts and avoided !! operators ..

Feel free to ask for changes if anything looks wrong to you. I can also comment unclear parts if needed.

All the best,
Narval

Refactor attachments to be able to find the attachment file name, refactor toRecipients to use a list instead of two separate fields, clean some warnings
@NarvalNudiste
Copy link
Contributor Author

This should solve #46

@nedimf nedimf self-requested a review December 21, 2022 14:05
@nedimf
Copy link
Owner

nedimf commented Dec 21, 2022

Amazing work! Thank you for submission.Approved @NarvalNudiste

I'll merge it in few hours

Copy link
Owner

@nedimf nedimf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nedimf nedimf merged commit 360b1f3 into nedimf:master Dec 22, 2022
@adrixgc
Copy link

adrixgc commented Dec 22, 2022

Thanks for taking care of the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants