Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookstore: add reducers and actions #2

Merged
merged 4 commits into from Jun 21, 2022
Merged

Bookstore: add reducers and actions #2

merged 4 commits into from Jun 21, 2022

Conversation

nedjwab
Copy link
Owner

@nedjwab nedjwab commented Jun 21, 2022

✨In This pull request i :

  • Add React-Redux.
  • Structure the files using a "feature folder" approach and use the ducks' pattern for the Redux files.
  • Write the book's actions and reducer.
  • Write the categories actions and reducer.
  • Configure the Redux Store.
  • Fix linter errors.

Copy link

@OmarRamoun OmarRamoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Project Approved! 🏆

Hi @nedjwab 👋

Your project is complete! ✔️ 🏁

Your code was very professional 💯 and I can see you have a great chance to be a Great Software Engineer ⛑️.

There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉. And Welcome to Microverse 👋.

Note: You can now take a break even if short before you move on to the next project. Happy 😄 Coding 🖥️! and Have a nice day 🌞.

Highlights 🌟

  • ✔️ Descriptive commmit messsages
  • ✔️ Descriptive PR description
  • ✔️ No linter Errors
  • The code is top-notch! 💯 and have a huge potential.

Cheers and Happy coding!👏👏👏

Important Notes 📝

  • Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
  • Please, remember to tag me in your question so I can receive the notification.

Thank you for your time 🙏 and call me if you need help or clarification ☎️

  • This is My GitHub: @omarramoun
  • This is My Twitter: @omarramoun
  • This is My Slack: Ramoun

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@nedjwab nedjwab merged commit dbc0661 into dev Jun 21, 2022
@nedjwab nedjwab deleted the reducers_actions branch June 23, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants