Testing React with Jest #7
Conversation
There was a problem hiding this comment.
Hi @nedjwab ,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
To Highlights
- All your tests are passing 👍
- GitHub workflow followed ✔️
- PR has a title and summary ✔️
Required Changes ♻️
- Please let's include the License section of the README file. This will render your README.md file professional.
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| @@ -0,0 +1,35 @@ | |||
| import calculate from '../logic/calculate'; | |||
|
|
|||
| describe('Test for calculate function', () => { | |||
There was a problem hiding this comment.
- All the functionalities and scenarios of the calculate module should be covered. Let's kindly cover the scenario where buttonName === 'AC ', buttonName === '.', buttonName === '+/-'.
There was a problem hiding this comment.
**STATUS: APPROVED 🟢 **
Hi @nedjwab ,
Great work on making the changes requested by a previous reviewer 👏🏻
Your project is complete! . There is nothing else to say other than... it's time to merge it 🍾🚢 
. Congratulations! 🎉💯🌟
Cheers and Happy coding! 👏 👏 👏
Feel free to leave any questions or comments in the PR thread by mentioning my Github username if something is not 100% clear.
As described in the Code reviews limits policy you have limited number of reviews per this project. If you think that the code review was not fair, you can request a second opinion using this form.
✨ In This pull request i :
-🚩 PS: I worked Solo on this project because my partner is not showing up Thank you for your understanding😊 .