New types and new theme for issue #33 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… noty alert (PS: onShow -> onShown and onClose -> onClosed)
needim
added a commit
that referenced
this pull request
May 22, 2012
New types and new theme for issue #33
|
Thanks @loicknuchel Very nice features! |
|
Thanks for accept my pull request. I will subit to you an other one related to my new issue (#36). Keep in touch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some new types for noty :
They explicit the alert type which had two different functions depending on what theme you use (default or twitter).
The alert type is keep for compatibility but I recommand to put it deprecated
I've also added a new theme : growl
It allows you to use header and icon sections to get a rich alert.
I hope you'll like my feature and accept them in your project.