Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert all TorchTyping to JaxTyping #164

Closed
neelnanda-io opened this issue Feb 4, 2023 · 2 comments · Fixed by #171
Closed

Convert all TorchTyping to JaxTyping #164

neelnanda-io opened this issue Feb 4, 2023 · 2 comments · Fixed by #171
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@neelnanda-io
Copy link
Collaborator

This project uses Patrick Kidger's torch typing to give tensor types including shapes. He recommends using JAXTyping for newer projects (not JAX specific, better maintained, more compatible with type checkers, etc) And it'd be good to update TL to use it.

@dkamm might be up your alley? Sorry if this invalidates your enum work, but might be a more elegant solution!
@neelnanda-io neelnanda-io added enhancement New feature or request good first issue Good for newcomers labels Feb 4, 2023
@neelnanda-io
Copy link
Collaborator Author

Hopefully addresses #155

@dkamm
Copy link
Contributor

dkamm commented Feb 4, 2023

@neelnanda-io Happy to check it out! And no worries, I'm all for dropping it for something better :)

@dkamm dkamm mentioned this issue Feb 12, 2023
Merged
@gsarti gsarti mentioned this issue Mar 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace torchtyping with jaxtyping dkamm/TransformerLens
2 participants
@dkamm @neelnanda-io