Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support /api/v1/admin/domain_blocks #741

Merged
merged 11 commits into from
Dec 4, 2022

Conversation

JacksonSamuel42
Copy link
Contributor

No description provided.

@neet
Copy link
Owner

neet commented Dec 3, 2022

@JacksonSamuel42 Is this ready for review? #739 (comment) and #739 (review) are not seemed to be fixed

It should be a singular DomainBlock

Masto.js internally converts property names from snake_case to camelCase to comply with JS conventions, so please update all snake_cases to annotate types properly

@JacksonSamuel42
Copy link
Contributor Author

@neet sorry I forget to check

@JacksonSamuel42
Copy link
Contributor Author

all changes implemented

src/entities/admin/domain-block.ts Outdated Show resolved Hide resolved
src/repositories/admin/domain-blocks-repository.ts Outdated Show resolved Hide resolved
src/repositories/admin/domain-blocks-repository.ts Outdated Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
@neet neet changed the title Admin domain blocks adding the new v4 admin API endpoints - fixing the inplementation Support /api/v1/admin/domain_blocks Dec 4, 2022
@neet neet merged commit 005e749 into neet:main Dec 4, 2022
github-actions bot pushed a commit that referenced this pull request Dec 5, 2022
# [4.8.0](v4.7.5...v4.8.0) (2022-12-05)

### Bug Fixes

* Fix Card.{width,height} to be number ([#745](#745)) ([8941096](8941096)), closes [#737](#737)
* Fix CreatePushSubscriptionParams#policy to be on the root and required ([80ee853](80ee853))
* Fix domain blocks to follow the naming convention ([ab8191b](ab8191b))

### Features

* Support /api/v1/admin/domain_allows ([#744](#744)) ([dbdf59f](dbdf59f))
* Support `/api/v1/admin/domain_blocks` ([#741](#741)) ([005e749](005e749))
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

🎉 This PR is included in version 4.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@JacksonSamuel42 JacksonSamuel42 deleted the admin-domain-blocks branch December 5, 2022 10:51
ayoayco pushed a commit to ayoayco/masto.js that referenced this pull request Dec 5, 2022
# [4.8.0](neet/masto.js@v4.7.5...v4.8.0) (2022-12-05)

### Bug Fixes

* Fix Card.{width,height} to be number ([neet#745](neet#745)) ([8941096](neet@8941096)), closes [neet#737](neet#737)
* Fix CreatePushSubscriptionParams#policy to be on the root and required ([80ee853](neet@80ee853))
* Fix domain blocks to follow the naming convention ([ab8191b](neet@ab8191b))

### Features

* Support /api/v1/admin/domain_allows ([neet#744](neet#744)) ([dbdf59f](neet@dbdf59f))
* Support `/api/v1/admin/domain_blocks` ([neet#741](neet#741)) ([005e749](neet@005e749))
This was referenced Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants