Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time complexity to all solutions #548

Open
abe-101 opened this issue Jul 20, 2022 · 3 comments
Open

Add time complexity to all solutions #548

abe-101 opened this issue Jul 20, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@abe-101
Copy link
Contributor

abe-101 commented Jul 20, 2022

In the walk through video's you go through the time and space complexity of any given problem.
I thought it would be nice if we added the time and space complexity on the site neetcode.io associated with each problem.

One approach could be to hard code it on the site.
Another rather simpler approach would be to have it in the github file with the code for each algorithm.

@Ahmad-A0 Ahmad-A0 added website-only Issues that apply solely to the neetcode.io website enhancement New feature or request and removed website-only Issues that apply solely to the neetcode.io website labels Jul 21, 2022
@nimpadjio
Copy link

Hi, i will like to help add this feature using javascript. Are you guys okay with that?

@abe-101
Copy link
Contributor Author

abe-101 commented Jan 15, 2023

Any thoughts on this?

What if we added a requirement in the pull request template to include the time and space complexity?
This way new problems would include the time and space complexity in the file
and with time we can slowly add the time and space complexity the existing problems

@abe-101 abe-101 changed the title Add time complexity to neetcode.io Add time complexity to all solutions Jan 15, 2023
@abe-101
Copy link
Contributor Author

abe-101 commented Jan 15, 2023

I see some problems already have it
creating a "standard" format in the readme and in the pull request template would great enhance neetcode.io as well as the leetcode-bot

Heres a javascript problem that includes the complexity.
image
Heres python problem without:
Screenshot from 2023-01-15 11-23-30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants