Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Webpack 4? #15

Closed
Nickersoft opened this issue Mar 1, 2018 · 3 comments
Closed

Support for Webpack 4? #15

Nickersoft opened this issue Mar 1, 2018 · 3 comments

Comments

@Nickersoft
Copy link
Contributor

Are there any plans to adapt this plugin for Webpack 4? I could try my hand at a pull request if you're too busy. Currently using this plugin with Webpack 4 renders the following error:

ERROR in   TypeError: callback is not a function
      
      - index.js:65 HtmlWebpackPugPlugin.preProcessHtml
        [homepage]/[html-webpack-pug-plugin]/index.js:65:3
      
      - index.js:14 
        [homepage]/[html-webpack-pug-plugin]/index.js:14:12
      
      
      - new Promise
      
      
      - Hook.js:35 AsyncSeriesWaterfallHook.lazyCompileHook [as _promise]
        [homepage]/[tapable]/lib/Hook.js:35:21
      
      - index.js:645 
        [homepage]/[html-webpack-plugin]/index.js:645:47
      
      - index.js:173 Promise.resolve.then.then.then.then.then.then.html
        [homepage]/[html-webpack-plugin]/index.js:173:18
      
      
      - next_tick.js:160 process._tickCallback
        internal/process/next_tick.js:160:7
@Nickersoft
Copy link
Contributor Author

Nickersoft commented Mar 1, 2018

@negibouze Went ahead and made a PR: #16

@negibouze
Copy link
Owner

@Nickersoft Thank you for your Report & PR.

@negibouze
Copy link
Owner

@Nickersoft
I released a new version(v0.3.0).
Thank you for your cooperation :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants