Skip to content
This repository has been archived by the owner on Nov 8, 2023. It is now read-only.

Standalone #6

Merged
merged 3 commits into from May 13, 2020
Merged

Standalone #6

merged 3 commits into from May 13, 2020

Conversation

jbygdell
Copy link
Collaborator

@jbygdell jbygdell commented May 5, 2020

Describe the pull request:

  • Bug fix
  • Functional change
  • New feature
  • Code cleanup
  • Build system change
  • Documentation change
  • Language translation

Pull request long description:

Modifies the entrypoint script to generate a federated or stand alone configuration based on if the CEGA_CONNECTION ENV is defined or not.

Changes made:

  1. Extended the entrypoint script to generate a stand alone config
  2. Fixed the chmod command for the certificates
  3. Renamed the entrypoint script from ega-entrypoint to docker-entrypoint

Related issues:

Additional information:

Release note:

Documentation change:

Mentions:

Sets up the MQ for standalone configuration when the ENV `CEGA_CONNECTION`
is absent
One further step in migrating from the (l)ega naming schema.
@jbygdell jbygdell added the enhancement New feature or request label May 5, 2020
@jbygdell jbygdell requested review from blankdots and dtitov May 5, 2020 10:13
@jbygdell jbygdell self-assigned this May 5, 2020
@jbygdell jbygdell added this to In progress in Sensitive Data Archive Development via automation May 5, 2020
@blankdots blankdots moved this from In progress to Review in progress in Sensitive Data Archive Development May 5, 2020
Sensitive Data Archive Development automation moved this from Review in progress to Reviewer approved May 7, 2020
Copy link
Member

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for standalone we might need just files.inbox, (maybe) files, errors, stableIDs and completed.

We need to modify hard-coded publish of errors to cega exchange in neicnordic/LocalEGA, or we can create a binding for it to route internally, either way it think we need to make changes to neicnordic/LocalEGA code.

a biding such as:

{
      "source": "cega",
      "vhost": "${MQ_VHOST:-/}",
      "destination": "errors",
      "destination_type": "queue",
      "routing_key": "errors",
      "arguments": {}
    }

This being said, we could approve as is and change later as we change the code for neicnordic/LocalEGA

@jbygdell
Copy link
Collaborator Author

jbygdell commented May 7, 2020

There are a lot of hard coded stuff in the python code that needs to be looked at.

@blankdots
Copy link
Member

tracked here: neicnordic/LocalEGA#33

@blankdots blankdots merged commit 3531a6d into master May 13, 2020
Sensitive Data Archive Development automation moved this from Reviewer approved to Done May 13, 2020
@blankdots blankdots deleted the standalone branch July 30, 2020 08:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

2 participants