Changed calls to File::Compare::compare() to run in 'text mode' by ad…

…ding a -1 argument. Suggested by Max, commenting on the bug in RT. bug #56642
neilb · Feb 12, 2012 · 84c6603 · 84c6603
1 parent e6a005a
commit 84c6603
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/Changes b/Changes
@@ -2,6 +2,9 @@ Revision history for perl distribution Graph-ReadWrite
 
 2.01 2012-02-12
 
+    - changed calls to File::Compare::compare() to hopefully cope with
+      EOL differences between Windows and Unix. Reported by Philip Potter,
+      and fix noted by Max
     - renamed ChangeLog to Changes and reformatted as per CPAN::Changes::Spec
 
 2.00 2005-01-02

diff --git a/t/reader.t b/t/reader.t
@@ -55,7 +55,7 @@ $writer = Graph::Writer::HTK->new();
 if (defined($reader) && defined($writer)
     && ($ingraph = $reader->read_graph($testfile))
     && $writer->write_graph($ingraph, $genfile)
-    && compare($genfile, $testfile) == 0)
+    && compare($genfile, $testfile, -1) == 0)
 {
     print "ok 2\n";
 } else {

diff --git a/t/simple.t b/t/simple.t
@@ -36,7 +36,7 @@ $expected = 't/data/simple.xml';
 $writer = Graph::Writer::XML->new();
 if (defined($writer)
     && $writer->write_graph($graph, $genfile)
-    && compare($genfile, $expected) == 0)
+    && compare($genfile, $expected, -1) == 0)
 {
     print "ok 1\n";
 } else {
@@ -52,7 +52,7 @@ $expected = 't/data/simple.htk';
 $writer = Graph::Writer::HTK->new();
 if (defined($writer)
     && $writer->write_graph($graph, $genfile)
-    && compare($genfile, $expected) == 0)
+    && compare($genfile, $expected, -1) == 0)
 {
     print "ok 2\n";
 } else {
@@ -68,7 +68,7 @@ $expected = 't/data/simple.dot';
 $writer = Graph::Writer::Dot->new();
 if (defined($writer)
     && $writer->write_graph($graph, $genfile)
-    && compare($genfile, $expected) == 0)
+    && compare($genfile, $expected, -1) == 0)
 {
     print "ok 3\n";
 } else {
@@ -84,7 +84,7 @@ $expected = 't/data/simple.vcg';
 $writer = Graph::Writer::VCG->new();
 if (defined($writer)
     && $writer->write_graph($graph, $genfile)
-    && compare($genfile, $expected) == 0)
+    && compare($genfile, $expected, -1) == 0)
 {
     print "ok 4\n";
 } else {
@@ -100,7 +100,7 @@ $expected = 't/data/simple.davinci';
 $writer = Graph::Writer::daVinci->new();
 if (defined($writer)
     && $writer->write_graph($graph, $genfile)
-    && compare($genfile, $expected) == 0)
+    && compare($genfile, $expected, -1) == 0)
 {
     print "ok 5\n";
 } else {