Skip to content
This repository has been archived by the owner on Jul 10, 2020. It is now read-only.

FormLabel is incompatible with formLabel from ZF2 #186

Open
guilherme-santos opened this issue Oct 22, 2016 · 3 comments
Open

FormLabel is incompatible with formLabel from ZF2 #186

guilherme-santos opened this issue Oct 22, 2016 · 3 comments
Assignees

Comments

@guilherme-santos
Copy link
Contributor

Hi,

https://github.com/neilime/zf2-twb-bundle/blob/master/src/TwbBundle/View/Helper/TwbBundleLabel.php#L33 In this line you're expecting for a string while FormLabel from ZF2 is expect an element https://github.com/zendframework/zend-form/blob/master/src/View/Helper/FormLabel.php#L43 you should remain compatible, right?

@neilime
Copy link
Owner

neilime commented Nov 3, 2016

Hi,

The class TwbBundle\View\Helper\TwbBundleLabel does not render form label, it renders bootstrap label (http://getbootstrap.com/components/#labels)

@neilime neilime self-assigned this Nov 3, 2016
@neilime neilime added the bug label Nov 3, 2016
@neilime
Copy link
Owner

neilime commented Nov 3, 2016

You're right !
I have fixed the config, please let me know if it works for you now

Thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants