Don't override manager if it's in the arguments. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Looks good. Do you think you could also add a test to maintain the level of coverage? |
|
Done, see philb61@f6d1a12 |
|
Great, thanks a lot! |
|
@neithere I see that there is no new version for a long time. This patch is needed for working with Django1.8+ P.S. I know that the issue tracker is in Bibucket, but I have some trouble with logging in because of their account migration process. |
|
I agree. Right now, we use a specific commit in the file we use to tell pip what to install. It would be much nicer to be able to tell it to use a correct version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bitbucket.org/neithere/django-autoslug/issues/34/django-migrations-fail-i