Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-Proc does not fix relative jumps in trampoline functions #22

Closed
bo3b opened this issue Jan 21, 2018 · 5 comments
Closed

In-Proc does not fix relative jumps in trampoline functions #22

bo3b opened this issue Jan 21, 2018 · 5 comments

Comments

@bo3b
Copy link

bo3b commented Jan 21, 2018 •
edited
Loading

Please see:
bo3b/3Dmigoto#87

In this specific case, the JNE instruction is moved into the stub, and is not fixed there, which means it's a relative jne to nowhere.

Tested in top-of-tree, and bug still exists.
@mxmauro
Copy link
Contributor

mxmauro commented Jan 22, 2018

Hi @bo3b and @DarkStarSword, I've implemented the changes. Currently testing. I'll use this issue to notify about changes.

@mxmauro
Copy link
Contributor

mxmauro commented Jan 22, 2018

Uploaded changes. Please let me know if they work for you.

@DarkStarSword
Copy link

Excellent - I've tested the VSSetSamplers case and can confirm this is working for me :)

I'll do some more smoke screen testing on the other hooks, but I think this is resolved and we can close the bug - thanks :)

@bo3b
Copy link
Author

bo3b commented Jan 23, 2018

Yes, looking good.

Thanks very much for the quick response.

@bo3b bo3b closed this as completed Jan 23, 2018
@mxmauro
Copy link
Contributor

mxmauro commented Jan 23, 2018 •
edited
Loading

Excellent guys.

Kind regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DarkStarSword @mxmauro @bo3b