Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't build? #7

Closed
bo3b opened this issue Apr 15, 2016 · 3 comments
Closed

Doesn't build? #7

bo3b opened this issue Apr 15, 2016 · 3 comments

Comments

@bo3b
Copy link

bo3b commented Apr 15, 2016

If I do a git clone of the repository, the project structure does not seem to match the code.

Looking just at NktHookLib to be built, I get:

1>..\Lib\libudis86\amalgamation.c(33): fatal error C1083: Cannot open include file: 'source\libudis86\decode.h': No such file or directory

amalgamation.c has includes of:

#include "stdint.h"
#include "source\libudis86\decode.h"
#include "source\libudis86\extern.h"

And the path source\libudis86\ does not exist.

Here is how the hierarchy looks:

image

Decode.h is under tables not source and in any case is under ``libudis86` not above it.

image

Visual Studio 2013.

I'm sure I can get it building, I just figured you might want to know.

@bo3b bo3b changed the title Doesn't build Doesn't build? Apr 15, 2016
@bo3b
Copy link
Author

bo3b commented Apr 15, 2016

Hmmm... I see. Submodules. Not my favorite.

Please add a note to your front page ReadMe, that makes it clear that you have to do
git clone --recursive for this to work.

Your instructions in INSTALLATION & USAGE are incomplete.

@scnale
Copy link
Contributor

scnale commented Apr 22, 2016

Fixed in 11b39d7.

@scnale scnale closed this as completed Apr 22, 2016
@bo3b
Copy link
Author

bo3b commented Apr 23, 2016

Cool, thanks for making that more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants