Sandbox - LINK is sent via POST with _method parameter (UNLINK is not)

[JakubFojtik]

Sending a LINK request is done via method faking, so it sends a POST.
I believe it is a bug, since UNLINK and other methods are used directly.
Also, since LINKing is used on a non-collection resource like /something/1, the POST method would be disabled on it and a '405 Method Not Allowed' error is thrown.

If it is because of the firefox bug, that one seems to be fixed already.

[willdurand]

Yes, that's because of Firefox's bug. Should we change this behavior now? Willing to work on it?

[tonivdv]

Hello @willdurand ,

I've got this issue with Google Chrome as well ...

The lines causing the issue is in the file "layout.html.twig" starting at line 524

// Workaround for Firefox bug and a thereby resulting nginx incompatibility
if (method == "LINK") {
  method = "POST";
  params._method = "LINK";
}

Fix from 4fa50eb

Reverting this works on Chrome. If it's a firefox workaround, maybe it should only be executed when it's a firefox browser?

Let me know your thoughts, and I can PR if needed.

Cheers

[willdurand]

Let's apply this fix only on Firefox then :)

[tonivdv]

@willdurand Will do ;)

[tonivdv]

@willdurand I just checked with firefox ... it fails too ... so I guess we can simply remove it? /cc @JakubFojtik

[willdurand]

@tonivdv ok then

[foaly-nr1]

Any progress on this? 👍

[tonivdv]

@foaly-nr1 Well I PR a change, but it made test fail however I don't get why they failed.