Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation on updated observation space and missing gym space definition #17

Closed
sibocw opened this issue May 2, 2023 · 1 comment
Closed

Documentation on updated observation space and missing gym space definition #17

sibocw opened this issue May 2, 2023 · 1 comment
Assignees
@stimpfli
Labels
documentation Improvements or additions to documentation enhancement mujoco
Milestone
TODOs for the 1.0...

Comments

@sibocw
Copy link
Contributor

sibocw commented May 2, 2023

  1. End effector position and contact force sensor readings are not added to NeuroMechFlyMuJoCo.observation_space
  2. They are not explained on the docs site
@sibocw sibocw self-assigned this May 2, 2023
sibocw added a commit that referenced this issue May 2, 2023
@sibocw
add new entry to observation space definition, update docs, address #17
e518f79
sibocw added a commit that referenced this issue May 2, 2023
@sibocw
Merge pull request #18 from NeLy-EPFL/fix-obs-space-def
f806314 
add new entry to observation space definition, update docs, address #17
@sibocw
Copy link
Contributor Author

sibocw commented May 2, 2023

I tentatively fixed it in #18 (sorry for not having you review it; i wanted to website to be updated asap).

However, I think we should change the shape of the end effector position array from (18,) to (3, 6), with x, y, z each on one row. This way it's easier to use.

Let's keep this in mind for the 1.0 version after COBAR is over? @stimpfli

@sibocw sibocw added bug Something isn't working documentation Improvements or additions to documentation mujoco labels May 2, 2023
@sibocw sibocw added this to the TODOs for the 1.0 version milestone May 2, 2023
@sibocw sibocw added enhancement and removed bug Something isn't working labels May 2, 2023
@sibocw sibocw assigned stimpfli and unassigned sibocw Jun 9, 2023
@sibocw sibocw closed this as completed Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stimpfli stimpfli

Labels
documentation Improvements or additions to documentation enhancement mujoco
Projects
None yet
Milestone
TODOs for the 1.0 version
Development

No branches or pull requests
2 participants
@sibocw @stimpfli