-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Previous merged commit used when a PR is modified #94
Comments
There are several Issues and posts concerning this problem: The current workaround is to enable the I would propose the integration of the following workaround: |
I've since looked at the code and I would still recommend
|
For anybody else stumbling over this issue: consider merging locally. |
When a PR is updated with a new commit, sometimes the plugin uses the previous merged commit rather than the new one.
Possible cause of the issue: I understood that Stash is building the merged commit/branch (
origin/pr/${pullRequestId}/merge
) in the background, so I suspect that there is a bad timing condition that is if the plugin query the PR and find it to be changed, it will pull theorigin/pr/${pullRequestId}/merge
branch before it is actually updated with the new merge commit.This is quite annoying as it is hard to be sure that the test are passed with the latest changes!
Other than that, thx for the plugin it is great ! :)
The text was updated successfully, but these errors were encountered: