Network fees infomation #317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AnthonyLaw, you might want to wait a bit until this is merged to just call one endpoint: symbol/catapult-rest#251 |
dgarcia360
reviewed
Feb 7, 2020
dgarcia360
reviewed
Feb 7, 2020
src/infrastructure/getStatistics.js
Outdated
|
|
||
| const getAverageNetworkFees = async () => { | ||
| const maxDifficultyBlocks = await sdkBlock.getBlocksFromHeightWithLimit(Constants.NetworkConfig.MAX_DIFFICULTY_BLOCKS) | ||
| const maxDifficultyBlocksFeeMultipliers = maxDifficultyBlocks.map(({ feeMultiplier }) => parseFloat(feeMultiplier) > 0 ? parseFloat(feeMultiplier) : Constants.NetworkConfig.DEFAULT_DYNAMIC_FEE_MULTIPLIER / Math.pow(10, Constants.NetworkConfig.NATIVE_MOSAIC_DIVISIBILITY)) |
There was a problem hiding this comment.
Constants.NetworkConfig.DEFAULT_DYNAMIC_FEE_MULTIPLIER only applies to rental fees, not to transaction fees recommendation.
There was a problem hiding this comment.
right, thanks for clearify
@dgarcia360 Glad to know that, Thanks. |
evias
approved these changes
Mar 16, 2020
|
refer #388 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved: #267
Added
Recommended Network fees
myself define the network rate for
Fast : 3andSlow : 0.5taking the
rate * averageNetworkFees=Recommended Network feesEffective Rental Fees
I refer the calculation here
namespaceRentalEffectiveFee = rootNamespaceRentalFeePerBlock * medianNetworkMultipliermedianNetworkMultiplier = 0.000282
rootNamespaceRentalFeePerBlock = 0.000001
The fees i will get
0.000000000282with fix 6 decimal0.000000which is something wrong.need input from you guys.
@dgarcia360 @evias