Added qrencode QML plugin #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://gitorious.org/project-grande/qrencoder-declarative-plugin Signed-off-by: Tom Swindell <t.swindell@rubyx.co.uk>
| * | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program; if not, write to the Free Software | ||
| * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.#ifndef GRANDEWEBRUNTIME_H |
There was a problem hiding this comment.
I don't think that ifndef belongs there :-p
|
I assume a relicense (GPLv2 -> LGPL, at least) is out of the question? |
- Minor source change to make more succinct - Removed "ordered" CONFIG from qrencoder.pro - Fixed erroneous installation path for qmldir in qrencoder.pro Signed-off-by: Tom Swindell <t.swindell@rubyx.co.uk>
|
Updated |
| @@ -0,0 +1,4 @@ | |||
| TEMPLATE = subdirs | |||
| CONFIG = ordered | |||
There was a problem hiding this comment.
no need for ordered here: you only have one subdir and this will (inadvertently) make it slow when you add more.
the correct way to do things is to use .depends on a target, btw, not use ordered builds - except as a last resort
Signed-off-by: Tom Swindell <t.swindell@rubyx.co.uk>
| CONFIG = qt plugin link_pkgconfig | ||
|
|
||
| packagesExist(libqrencode) { | ||
| PKGCONFIG += libqrencode |
There was a problem hiding this comment.
one more trick which we'll have to do, is to set DEFINES += HAVE_QRENCODE, and in the source, guard all includes/usages of API with it
…encode backend. Signed-off-by: Tom Swindell <t.swindell@rubyx.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gitorious.org/project-grande/qrencoder-declarative-plugin
Signed-off-by: Tom Swindell t.swindell@rubyx.co.uk