Change initialization to prevent crash, NEMO#604 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move init_kernel_notification() to happen before init_first_boot_hwclock_time_adjustment_check(). If the file /var/cache/timed/first-boot-hwclock.dat is missing, then timed tries to set the system time in init_first_boot_hwclock_time_adjustment_check(). The function tries to stop kernel time change monitoring, which caused timed to segfault as the object responsible for monitoring time change was created in init_kernel_notification(), which was called after init_first_boot_hwclock_time_adjustment_check().
pgerdt
pushed a commit
that referenced
this pull request
Jan 21, 2013
Change initialization to prevent crash, NEMO#604
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move init_kernel_notification() to happen before
init_first_boot_hwclock_time_adjustment_check().
If the file /var/cache/timed/first-boot-hwclock.dat
is missing, then timed tries to set the system time in
init_first_boot_hwclock_time_adjustment_check().
The function tries to stop kernel time change
monitoring, which caused timed to segfault as
the object responsible for monitoring time change
was created in init_kernel_notification(), which
was called after
init_first_boot_hwclock_time_adjustment_check().