This repository has been archived by the owner on Jun 10, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarcia360
suggested changes
Jan 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! Only a few minor comments. As the next steps we need to:
- Think about testing each table and builder.
- Replace every transaction command table formatter (e.g. https://github.com/nemtech/nem2-cli/blob/master/src/commands/transaction/accountaddressrestriction.ts#L79) for the new one.
src/views/transactions/transactionDetails/AccountMetadataView.ts
Outdated
Show resolved
Hide resolved
decentraliser
force-pushed
the
tx-details
branch
from
January 28, 2020 12:38
0228a65
to
3b2b5c5
Compare
I fixed the unit test of |
dgarcia360
suggested changes
Jan 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @decentraliser, only a few class + files names changes to match the SDK.
src/views/transactions/details/transaction-types/accountRestrictionAddress.view.ts
Outdated
Show resolved
Hide resolved
src/views/transactions/details/transaction-types/accountRestrictionMosaic.view.ts
Outdated
Show resolved
Hide resolved
src/views/transactions/details/transaction-types/accountRestrictionOperation.view.ts
Outdated
Show resolved
Hide resolved
src/views/transactions/details/transaction-types/linkAccount.view.ts
Outdated
Show resolved
Hide resolved
src/views/transactions/details/transaction-types/modifyMultisigAccount.view.ts
Outdated
Show resolved
Hide resolved
src/views/transactions/details/transaction-types/registerNamespace.view.ts
Outdated
Show resolved
Hide resolved
@decentraliser Could add unit tests for the following files?
Also, I was wondering if makes sense for you to move
to
|
dgarcia360
approved these changes
Jan 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing a WIP for a preliminary review @dgarcia360
Currently, the
account transactions
command is stableI'd like to have your preferences in terms of files naming and files locations, as well as any other comment
Also, would you have any idea about a clean way to test all transaction types against the tables, please tell me