Currency and CurrencyService #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rg911
suggested changes
Oct 19, 2020
Docs fixes
|
@rg911 I've renamed They may be a network mosaic/alias or a custom/user mosaic/alias. I've also done the fixes as requested. Docs will require a big update. All the hardcoded values in the typescript examples can be removed.
|
Mosaic id is prefered when loading from rest. Removed hardcoded mosaic id from public
|
@rg911 could you review? This PR doesn't require a rest update like the next ones. |
rg911
reviewed
Oct 26, 2020
| /** | ||
| * An object that knows how to create Mosaics based on the Mosaic Info and Namespace configuration. | ||
| */ | ||
| export class Currency { |
There was a problem hiding this comment.
Shall we call it NetworkCurrency instead of Currency? to differentiate with other tokens might be created by users
There was a problem hiding this comment.
That's the thing, Currency supports user-created mosaics...
You can create user mosaic for transfers using the currency objects.
rg911
approved these changes
Oct 26, 2020
rg911
added a commit
that referenced
this pull request
Dec 8, 2020
* Updated Travis. Using travis function submodule * Fixed e2e script * Currency and CurrencyService (#695) * Network Currency and Service * Code improvements * Renamed NetworkCurrency with Currency Docs fixes * Removed cache from service. The repository factory caches them * Fixed lazy loading cache * Improved e2e for travis cron Mosaic id is prefered when loading from rest. Removed hardcoded mosaic id from public * Fixed lint error * Fixed build * Updated bootstrap * create-index-files npm command (#701) Generates the index.ts automatically * Revisit how npm package is created (#702) * Updated open api to latest alpha (Requires New Rest) (#698) * Fixed #672 - Added finalization http * Security alert fix * Updated libs * Updated open api to latest alpha Added secret filter in secret lock search Updated transaction search * Improved e2e tests * Increased timeout * Fixed build error Co-authored-by: Steven Liu <xian.f.liu@gmail.com> * Typo in docs of PublicAccount.ts (#703) * UnlockedAccount endpoint and latest openAPI changes (#706) * Fixed #705 - Added unlocked account endpoint - Applied latest changes from openAPI * Updated open api to latest alpha (Requires New Rest) (#698) * Fixed #672 - Added finalization http * Security alert fix * Updated libs * Updated open api to latest alpha Added secret filter in secret lock search Updated transaction search * Improved e2e tests * Increased timeout * Fixed build error Co-authored-by: Steven Liu <xian.f.liu@gmail.com> * Fixed #705 - Added unlocked account endpoint - Applied latest changes from openAPI * Updated change log Co-authored-by: fboucquez <fboucquez@gmail.com> * Added prettier-plugin-organize-imports to prettier. (#708) * Added prettier-plugin-organize-imports to prettier. It fixes all the unsued imports warnings and order conflicts. It's integrated with npm run style:fox * Updated openAPI spec for unlockedAccount (#710) * Updated openAPI spec for unlockedAccount * Added Peer param in unlocked account * Updated travis (#711) * PersistentDelegationRequestTransaction message bug fix (#709) * Fixed message parsing from dto and buffer * State serialization and Mako Catbuffer (#707) * message marker harvesting (#714) * Fixed persistentHarvesting message marker issue. * Working on persistent delegate harvest * Improved doc and unit tests Co-authored-by: fernando <fboucquez@gmail.com> * - Added nodePublicKey in NodeInfo (#719) - Cache nodePublicKey in RepoFactory * /Merkle endpoints (#717) * Added /merkle endpoints * Added new block type (#724) * Added new block type * PR feedbacks * Server 10.0.0.4 upgrade (#725) * V1 Transactions * Added voting key v1 and v2 * fixed lint * Fixed DTO mapping and improved unit test. * Fixed repository merkle name Fixed search criteria * Server duration parser and test refactor (#729) * - Fixed #728 - server duration parser and test refactor * Added more check in duration parser * All transaction related notification should take an unresolved address (#731) * issue-#664: change filter Address to be unresolved Address * [issue-664]: resolve transaction notification with unresolved address * [issue-664]: fix invalid address name in docs * [issue-664]: add some test case for unresolved address * Merkle proof + finalization proof + block type fixes (#727) Improved creation of streamers Finality proof fix Make nemesis/importance block optional Co-authored-by: fernando <fboucquez@gmail.com> * Fixed deadline is sometimes 1 sec different * instead of minus milsecs, minus secs, sinc server epochAdjustment is using secs * New Role types (#733) * Bump highlight.js from 10.1.2 to 10.4.1 (#735) Bumps [highlight.js](https://github.com/highlightjs/highlight.js) from 10.1.2 to 10.4.1. - [Release notes](https://github.com/highlightjs/highlight.js/releases) - [Changelog](https://github.com/highlightjs/highlight.js/blob/master/CHANGES.md) - [Commits](highlightjs/highlight.js@10.1.2...10.4.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 0.22.0 changelog (#732) * Updated version to 0.22.0 Updated changelog * Feedback changes * State proof fixes (#736) * Added version 1 fallback * removed log * Addes sort_key:keys (#737) * Updated change log (#738) * Version upgrades (#739) * Version upgrades * updated open api version Co-authored-by: Steven Liu <xian.f.liu@gmail.com> Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es> Co-authored-by: James Lin <54219053+james-lin71@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Steve, I've done a small refactoring to the NetworkCurrency object to align with Java.
NetworkCurrency is an object that knows how to create Mosaic (it's not a subclass of mosaic anymore). Now we can create NetworkCurrency based on the network configuration.
I've removed cat.currency and cat.harvest from the production code as these names are just generic that can be easily changed via bootstrap.
There is a NetworkCurrencyService that knows how to load/create NetworkCurrency objects. NetworkCurrency could also be loaded from user-provided mosaic id if desired.
Fixes #692
Fixes #693